Skip to content

no copying in write_any

Lee McCuller requested to merge github/fork/kevinkuns/write_any into main

Created by: kevinkuns

This changes the logic in write_any so that the dict to be saved is never copied or deepcopied since not all objects have __copy__ and __deepcopy__ methods.

This could potentially be simplified. Previously there was a variable fdict_orig whose only function, in practice, was to check if there were complex features in fdict. While the original fdict was getting deepcopied, I didn't see anywhere where this was important.

Note that load_any also has a variable fdict_orig that doesn't do anything at all. So maybe these are a holdover from some old code or maybe I'm missing something.

Merge request reports

Loading